README, removed applications section#30
Open
juanpabloaj wants to merge 1 commit intoericentin:masterfrom
Open
Conversation
|
The library certainly works without adding it as an application, but what the application does is register the translator. gen_state_machine/lib/gen_state_machine/application.ex Lines 1 to 11 in 77776ec This is to make it so that GenStateMachine termination messages are properly logged, see https://elixirforum.com/t/why-does-logger-translator-ignore-gen-statem-reports/37418. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe modify the application section is not necessary.
I tried this package on elixir 1.14.0 without modify the application section and it works.
I followed this tutorial
https://dockyard.com/blog/2020/01/31/state-timeouts-with-gen_statem
More details:
https://www.amberbit.com/blog/2017/9/22/elixir-applications-vs-extra_applications-guide/